Migrate org.eclipse.ui.workbench.texteditor.tests to JUnit 5 #3718
+238
−237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results 3 024 files +1 008 3 024 suites +1 008 2h 15m 22s ⏱️ + 31m 35s Results for commit cfe4a46. ± Comparison against base commit dd7a449. This pull request removes 2 and adds 7 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
vogella
force-pushed
the
wb.texteditor.tests
branch
from
b1dde02 to
65f9cad
Compare
akurtakov
reviewed
Feb 3, 2026
...xteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/revisions/HunkComputerTest.java
Show resolved
Hide resolved
akurtakov
reviewed
Feb 3, 2026
...nch.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/HippieCompletionTest.java
Outdated
Show resolved
Hide resolved
vogella
force-pushed
the
wb.texteditor.tests
branch
from
a3724d7 to
5f2fc4e
Compare
akurtakov
reviewed
Feb 3, 2026
...nch.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/HippieCompletionTest.java
Show resolved
Hide resolved
akurtakov
reviewed
Feb 3, 2026
...nch.texteditor.tests/src/org/eclipse/ui/workbench/texteditor/tests/HippieCompletionTest.java
Show resolved
Hide resolved
vogella
force-pushed
the
wb.texteditor.tests
branch
from
5f2fc4e to
2336d9f
Compare
akurtakov
approved these changes
Feb 3, 2026
Member
akurtakov
left a comment
akurtakov
left a comment
There was a problem hiding this comment.
Looks good to me. Please merge when tests succeed.
Contributor
Author
|
Thanks for the review @akurtakov |
vogella
force-pushed
the
wb.texteditor.tests
branch
from
2336d9f to
31c4ddf
Compare
vogella
force-pushed
the
wb.texteditor.tests
branch
from
31c4ddf to
cfe4a46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Changes:
* Replaced JUnit 4 imports (e.g., org.junit.Test,
org.junit.Assert) with JUnit 5 equivalents (org.junit.jupiter.api.Test, org.junit.jupiter.api.Assertions).
* Updated lifecycle annotations (@before -> @beforeeach, @after
-> @AfterEach).
* Updated assertEquals and assertFalse/assertTrue calls to match
JUnit 5's argument order (expected, actual, message / condition, message).
* Replaced ExpectedException usage and try-catch-fail blocks with
Assertions.assertThrows.
* Replaced @rule public TestName with TestInfo injection in test
methods and setup methods.
* Updated TextEditorPluginTest to use
@TestMethodOrder(MethodOrderer.MethodName.class) instead of @FixMethodOrder.